thaloco/banger
1
Fork 0
Code Pull requests Releases Packages Activity Actions

images: remove the docker field

Browse source 
The 'docker' bit on model.Image was unused at runtime — every code
path that branched on it had been removed earlier, leaving only the
field, the SQL column, the --docker flag, and the
#feature:docker sentinel that BuildMetadataPackages emitted into a
hash file. None of those have callers anymore.

Strip the field from the model, the API params, the SQLite column,
the CLI flag, and BuildMetadataPackages's signature. Add migration
2 (drop_images_docker) so existing installs lose the column on next
daemon start. ALTER TABLE ... DROP COLUMN is fine: SQLite has
supported it since 3.35 (2021).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Thales Maciel 2026-04-26 20:28:40 -03:00
parent 408ad6756c
commit 6c37fec17b
No known key found for this signature in database
GPG key ID: 33112E6833C34679
9 changed files with 23 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

11
internal/daemon/imagemgr/paths.go
View file

@ -129,14 +129,9 @@ func StageOptionalArtifactPath(artifactDir, stagedPath, name string) string {
}
// BuildMetadataPackages returns the canonical package set recorded for a
// managed image build. The #feature:docker sentinel is appended when
// docker is requested.
func BuildMetadataPackages(docker bool) []string {
packages := DebianBasePackages()
if docker {
packages = append(packages, "#feature:docker")
}
return packages
// managed image build.
func BuildMetadataPackages() []string {
return DebianBasePackages()
}
// WritePackagesMetadata writes the hash of packages next to rootfsPath so