Remove image build --from-image; doctor treats catalog images as OK
The `image build` flow spun up a transient Firecracker VM, SSHed in, and ran a large bash provisioning script to derive a new managed image from an existing one. It overlapped heavily with the golden- image Dockerfile flow (same mise/docker/tmux/opencode install logic duplicated in Go as `imagemgr.BuildProvisionScript`) and had far more machinery: async op state, RPC begin/status/cancel, webui form + operation page, preflight checks, API types, tests. For custom images, writing a Dockerfile is simpler and more reproducible. Removed end-to-end: - CLI `image build` subcommand + `absolutizeImageBuildPaths`. - Daemon: BuildImage method, imagebuild.go (transient-VM orchestration), image_build_ops.go (async begin/status/cancel), imagemgr/build.go (the 247-line provisioning script generator and all its append* helpers), validateImageBuildPrereqs + addImageBuildPrereqs. - RPC dispatches for image.build / .begin / .status / .cancel. - opstate registry `imageBuildOps`, daemon seam `imageBuild`, background pruner call. - API types: ImageBuildParams, ImageBuildOperation, ImageBuildBeginResult, ImageBuildStatusParams, ImageBuildStatusResult; model type ImageBuildRequest. - Web UI: Backend interface methods, handlers, form, routes, template branches (images.html build form, operation.html build branch, dashboard.html Build button). - Tests that directly exercised BuildImage. Doctor polish (task C): - Drop the "image build" preflight section entirely (its raison d'être is gone). - Default-image check now accepts "not local but in imagecat" as OK: vm create auto-pulls on first use. Only flag when the image is neither locally registered nor in the catalog. Net: 24 files touched, 1,373 lines deleted, 25 added. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
ace4782fce
commit
ac7974f5b9
24 changed files with 25 additions and 1398 deletions
|
|
@ -58,33 +58,6 @@ type VMCreateStatusResult struct {
|
|||
Operation VMCreateOperation `json:"operation"`
|
||||
}
|
||||
|
||||
type ImageBuildStatusParams struct {
|
||||
ID string `json:"id"`
|
||||
}
|
||||
|
||||
type ImageBuildOperation struct {
|
||||
ID string `json:"id"`
|
||||
ImageID string `json:"image_id,omitempty"`
|
||||
ImageName string `json:"image_name,omitempty"`
|
||||
Stage string `json:"stage,omitempty"`
|
||||
Detail string `json:"detail,omitempty"`
|
||||
BuildLogPath string `json:"build_log_path,omitempty"`
|
||||
StartedAt time.Time `json:"started_at,omitempty"`
|
||||
UpdatedAt time.Time `json:"updated_at,omitempty"`
|
||||
Done bool `json:"done"`
|
||||
Success bool `json:"success"`
|
||||
Error string `json:"error,omitempty"`
|
||||
Image *model.Image `json:"image,omitempty"`
|
||||
}
|
||||
|
||||
type ImageBuildBeginResult struct {
|
||||
Operation ImageBuildOperation `json:"operation"`
|
||||
}
|
||||
|
||||
type ImageBuildStatusResult struct {
|
||||
Operation ImageBuildOperation `json:"operation"`
|
||||
}
|
||||
|
||||
type VMRefParams struct {
|
||||
IDOrName string `json:"id_or_name"`
|
||||
}
|
||||
|
|
@ -242,16 +215,6 @@ type VMWorkspacePrepareResult struct {
|
|||
Workspace model.WorkspacePrepareResult `json:"workspace"`
|
||||
}
|
||||
|
||||
type ImageBuildParams struct {
|
||||
Name string `json:"name,omitempty"`
|
||||
FromImage string `json:"from_image,omitempty"`
|
||||
Size string `json:"size,omitempty"`
|
||||
KernelPath string `json:"kernel_path,omitempty"`
|
||||
InitrdPath string `json:"initrd_path,omitempty"`
|
||||
ModulesDir string `json:"modules_dir,omitempty"`
|
||||
Docker bool `json:"docker,omitempty"`
|
||||
}
|
||||
|
||||
type ImageRegisterParams struct {
|
||||
Name string `json:"name,omitempty"`
|
||||
RootfsPath string `json:"rootfs_path,omitempty"`
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue