banger/internal/imagepull
Thales Maciel 2ebd2b64bb
imagepull: update stale package + BuildExt4 docs
The package doc in internal/imagepull/imagepull.go still described
a two-step Pull + Flatten + BuildExt4 pipeline and warned that the
resulting image was "suitable as input to `image build` but not
directly bootable" because ownership preservation was deferred.
That's been wrong for a while: ApplyOwnership
(internal/imagepull/ownership.go) restores tar-header uid/gid/mode
via a debugfs set_inode_field batch, and InjectGuestAgents
(internal/imagepull/inject.go) writes banger's guest-side assets
into the image. `image pull` now produces a directly bootable
rootfs end-to-end.

Updated:
  - imagepull.go package doc — describes the full
    Pull → Flatten → BuildExt4 → ApplyOwnership → InjectGuestAgents
    pipeline and drops the "Phase A limitations" list that spoke
    of deferred ownership.
  - ext4.go BuildExt4 doc — notes that the filesystem is root-owned
    via `-E root_owner=0:0` and points at ApplyOwnership as the
    step that handles per-file ownership, instead of the previous
    "see the package doc for the implications" handwave.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-23 14:34:25 -03:00
..
assets Generic kernel + init= boot path for OCI-pulled images 2026-04-16 20:12:56 -03:00
ext4.go imagepull: update stale package + BuildExt4 docs 2026-04-23 14:34:25 -03:00
firstboot.go Phase B-3: first-boot sshd install 2026-04-16 18:20:33 -03:00
firstboot_test.go Generic kernel + init= boot path for OCI-pulled images 2026-04-16 20:12:56 -03:00
flatten.go banger internal make-bundle: build image bundles from flat rootfs tars 2026-04-17 15:17:50 -03:00
imagepull.go imagepull: update stale package + BuildExt4 docs 2026-04-23 14:34:25 -03:00
imagepull_test.go imagepull.Pull: don't eager-open layer readers 2026-04-16 19:03:52 -03:00
inject.go Phase B-3: first-boot sshd install 2026-04-16 18:20:33 -03:00
inject_test.go Phase B-3: first-boot sshd install 2026-04-16 18:20:33 -03:00
ownership.go Phase B-1: ownership fixup via debugfs pass 2026-04-16 18:04:22 -03:00