banger/internal/daemon/logger_test.go

package daemon

import (
	"bytes"
	"context"
	"encoding/json"
	"errors"
	"fmt"
	"os"
	"path/filepath"
	"strings"
	"testing"

	"banger/internal/api"
	"banger/internal/model"
	"banger/internal/paths"
)

func TestNewDaemonLoggerEmitsJSONAtConfiguredLevel(t *testing.T) {
	var buf bytes.Buffer
	logger, level, err := newDaemonLogger(&buf, "")
	if err != nil {
		t.Fatalf("newDaemonLogger: %v", err)
	}
	if level != "info" {
		t.Fatalf("level = %q, want info", level)
	}

	logger.Debug("hidden debug")
	logger.Info("visible info", "vm_name", "otter")

	entries := parseLogEntries(t, buf.Bytes())
	if len(entries) != 1 {
		t.Fatalf("entry count = %d, want 1", len(entries))
	}
	if entries[0]["msg"] != "visible info" {
		t.Fatalf("msg = %v, want visible info", entries[0]["msg"])
	}
	if entries[0]["vm_name"] != "otter" {
		t.Fatalf("vm_name = %v, want otter", entries[0]["vm_name"])
	}
}

func TestStartVMLockedLogsBridgeFailure(t *testing.T) {
	ctx := context.Background()
	origVsockHostDevicePath := vsockHostDevicePath
	vsockHostDevicePath = filepath.Join(t.TempDir(), "vhost-vsock")
	t.Cleanup(func() {
		vsockHostDevicePath = origVsockHostDevicePath
	})
	binDir := t.TempDir()
	for _, name := range []string{
		"sudo", "ip", "dmsetup", "losetup", "blockdev", "truncate", "pgrep", "ps",
		"chown", "chmod", "kill", "e2cp", "e2rm", "debugfs", "mkfs.ext4", "mount",
		"umount", "cp",
	} {
		writeFakeExecutable(t, filepath.Join(binDir, name))
	}
	t.Setenv("PATH", binDir)

	firecrackerBin := filepath.Join(t.TempDir(), "firecracker")
	vsockHelper := filepath.Join(t.TempDir(), "banger-vsock-pingd")
	if err := os.WriteFile(firecrackerBin, []byte("#!/bin/sh\nexit 0\n"), 0o755); err != nil {
		t.Fatalf("write firecracker: %v", err)
	}
	if err := os.WriteFile(vsockHostDevicePath, []byte{}, 0o644); err != nil {
		t.Fatalf("write vsock host device: %v", err)
	}
	if err := os.WriteFile(vsockHelper, []byte("#!/bin/sh\nexit 0\n"), 0o755); err != nil {
		t.Fatalf("write vsock helper: %v", err)
	}
	rootfsPath := filepath.Join(t.TempDir(), "rootfs.ext4")
	kernelPath := filepath.Join(t.TempDir(), "vmlinux")
	for _, path := range []string{rootfsPath, kernelPath} {
		if err := os.WriteFile(path, []byte("artifact"), 0o644); err != nil {
			t.Fatalf("write %s: %v", path, err)
		}
	}

	runner := &scriptedRunner{
		t: t,
		steps: []runnerStep{
			{call: runnerCall{name: "ip", args: []string{"link", "show", "br-fc"}}, out: []byte("1: br-fc\n")},
			sudoStep("", errors.New("bridge up failed"), "ip", "link", "set", "br-fc", "up"),
		},
	}
	var buf bytes.Buffer
	logger, _, err := newDaemonLogger(&buf, "info")
	if err != nil {
		t.Fatalf("newDaemonLogger: %v", err)
	}

	vmDir := filepath.Join(t.TempDir(), "vm")
	vm := testVM("loggy", "image-loggy", "172.16.0.50")
	vm.Runtime.DNSName = ""
	vm.Runtime.VMDir = vmDir
	vm.Runtime.SystemOverlay = filepath.Join(vmDir, "system.cow")
	vm.Runtime.WorkDiskPath = filepath.Join(vmDir, "root.ext4")
	vm.Runtime.LogPath = filepath.Join(vmDir, "firecracker.log")
	vm.Runtime.MetricsPath = filepath.Join(vmDir, "metrics.json")
	image := testImage("image-loggy")
	image.RootfsPath = rootfsPath
	image.KernelPath = kernelPath

	d := &Daemon{
		layout: paths.Layout{RuntimeDir: filepath.Join(t.TempDir(), "runtime")},
		config: model.DaemonConfig{
			BridgeName:          "br-fc",
			BridgeIP:            model.DefaultBridgeIP,
			DefaultDNS:          model.DefaultDNS,
			FirecrackerBin:      firecrackerBin,
			VSockPingHelperPath: vsockHelper,
			StatsPollInterval:   model.DefaultStatsPollInterval,
		},
		runner: runner,
		logger: logger,
	}

	_, err = d.startVMLocked(ctx, vm, image)
	if err == nil || !strings.Contains(err.Error(), "bridge up failed") {
		t.Fatalf("startVMLocked() error = %v, want bridge failure", err)
	}
	runner.assertExhausted()

	entries := parseLogEntries(t, buf.Bytes())
	if !hasLogEntry(entries, map[string]string{"msg": "operation stage", "operation": "vm.start", "stage": "bridge", "vm_name": "loggy"}) {
		t.Fatalf("expected bridge stage log, got %v", entries)
	}
	if !hasLogEntry(entries, map[string]string{"msg": "operation failed", "operation": "vm.start", "vm_name": "loggy", "error": "bridge up failed"}) {
		t.Fatalf("expected operation failure log, got %v", entries)
	}
}

func TestBuildImagePreservesBuildLogOnFailure(t *testing.T) {
	ctx := context.Background()
	store := openDaemonStore(t)
	stateDir := filepath.Join(t.TempDir(), "state")
	imagesDir := filepath.Join(stateDir, "images")
	if err := os.MkdirAll(imagesDir, 0o755); err != nil {
		t.Fatalf("mkdir images dir: %v", err)
	}

	binDir := t.TempDir()
	for _, name := range []string{"sudo", "ip", "pgrep", "chown", "chmod", "kill", "iptables", "sysctl", "e2fsck", "resize2fs", "mkfs.ext4", "mount", "umount", "cp"} {
		writeFakeExecutable(t, filepath.Join(binDir, name))
	}
	t.Setenv("PATH", binDir)

	baseRootfs := filepath.Join(t.TempDir(), "base.ext4")
	kernelPath := filepath.Join(t.TempDir(), "vmlinux")
	packagesPath := filepath.Join(t.TempDir(), "packages.apt")
	sshKeyPath := filepath.Join(t.TempDir(), "id_ed25519")
	firecrackerBin := filepath.Join(t.TempDir(), "firecracker")
	vsockHelper := filepath.Join(t.TempDir(), "banger-vsock-pingd")
	for _, path := range []string{baseRootfs, kernelPath, packagesPath, sshKeyPath} {
		if err := os.WriteFile(path, []byte("artifact"), 0o644); err != nil {
			t.Fatalf("write %s: %v", path, err)
		}
	}
	if err := os.WriteFile(vsockHelper, []byte("#!/bin/sh\nexit 0\n"), 0o755); err != nil {
		t.Fatalf("write %s: %v", vsockHelper, err)
	}
	if err := os.WriteFile(firecrackerBin, []byte("#!/bin/sh\nexit 0\n"), 0o755); err != nil {
		t.Fatalf("write %s: %v", firecrackerBin, err)
	}
	runner := &scriptedRunner{
		t: t,
		steps: []runnerStep{
			{call: runnerCall{name: "ip", args: []string{"route", "show", "default"}}, out: []byte("default via 192.0.2.1 dev eth0\n")},
		},
	}

	var buf bytes.Buffer
	logger, _, err := newDaemonLogger(&buf, "info")
	if err != nil {
		t.Fatalf("newDaemonLogger: %v", err)
	}
	d := &Daemon{
		layout: paths.Layout{
			StateDir:  stateDir,
			ImagesDir: imagesDir,
		},
		config: model.DaemonConfig{
			RuntimeDir:          t.TempDir(),
			DefaultImageName:    "default",
			DefaultPackagesFile: packagesPath,
			SSHKeyPath:          sshKeyPath,
			FirecrackerBin:      firecrackerBin,
			VSockPingHelperPath: vsockHelper,
		},
		store:  store,
		runner: runner,
		logger: logger,
		imageBuild: func(ctx context.Context, spec imageBuildSpec) error {
			if _, err := fmt.Fprintln(spec.BuildLog, "builder-stdout"); err != nil {
				return err
			}
			if spec.BaseRootfs != baseRootfs || spec.KernelPath != kernelPath || spec.PackagesPath != packagesPath {
				t.Fatalf("unexpected image build spec: %+v", spec)
			}
			return errors.New("builder failed")
		},
	}

	_, err = d.BuildImage(ctx, api.ImageBuildParams{
		Name:       "broken-image",
		BaseRootfs: baseRootfs,
		KernelPath: kernelPath,
	})
	if err == nil || !strings.Contains(err.Error(), "inspect ") {
		t.Fatalf("BuildImage() error = %v, want build log hint", err)
	}

	buildLogs, globErr := filepath.Glob(filepath.Join(stateDir, "image-build", "*.log"))
	if globErr != nil {
		t.Fatalf("glob build logs: %v", globErr)
	}
	if len(buildLogs) != 1 {
		t.Fatalf("build log count = %d, want 1", len(buildLogs))
	}
	logData, readErr := os.ReadFile(buildLogs[0])
	if readErr != nil {
		t.Fatalf("read build log: %v", readErr)
	}
	if !strings.Contains(string(logData), "builder-stdout") {
		t.Fatalf("build log = %q, want builder output", string(logData))
	}
	runner.assertExhausted()

	entries := parseLogEntries(t, buf.Bytes())
	if !hasLogEntry(entries, map[string]string{"msg": "operation stage", "operation": "image.build", "stage": "launch_builder"}) {
		t.Fatalf("expected launch_builder log, got %v", entries)
	}
	if !strings.Contains(buf.String(), buildLogs[0]) {
		t.Fatalf("daemon logs = %q, want build log path %s", buf.String(), buildLogs[0])
	}
}

func parseLogEntries(t *testing.T, data []byte) []map[string]any {
	t.Helper()
	lines := bytes.Split(bytes.TrimSpace(data), []byte("\n"))
	if len(lines) == 1 && len(lines[0]) == 0 {
		return nil
	}
	entries := make([]map[string]any, 0, len(lines))
	for _, line := range lines {
		if len(bytes.TrimSpace(line)) == 0 {
			continue
		}
		var entry map[string]any
		if err := json.Unmarshal(line, &entry); err != nil {
			t.Fatalf("unmarshal log line %q: %v", string(line), err)
		}
		entries = append(entries, entry)
	}
	return entries
}

func hasLogEntry(entries []map[string]any, want map[string]string) bool {
	for _, entry := range entries {
		match := true
		for key, value := range want {
			if !strings.Contains(stringValue(entry[key]), value) {
				match = false
				break
			}
		}
		if match {
			return true
		}
	}
	return false
}

func stringValue(value any) string {
	return fmt.Sprint(value)
}