Fix the misleading make install path where banger and bangerd still depended on a repo checkout for Firecracker, guest artifacts, image builds, and the SSH key. Replace repo-root inference with an explicit runtime bundle model: resolve a runtime_dir from env/config/install layout, derive concrete artifact paths from it, and update the daemon, CLI, and image-build flow to use those paths. Keep repo_root only as an explicit compatibility alias instead of auto-detecting it. Teach customize.sh to run from a read-only bundled runtime tree while writing transient state under XDG/BANGER_STATE_DIR, and make make install copy the runtime assets into PREFIX/lib/banger so installed binaries stay usable outside the repo. Validate with go test ./..., make build, bash -n customize.sh, and make install DESTDIR=/tmp/banger-install PREFIX=/usr. An out-of-repo installed-binary smoke test was attempted, but this sandbox blocked bangerd from binding its Unix socket (setsockopt: operation not permitted).
136 lines
3.5 KiB
Go
136 lines
3.5 KiB
Go
package daemon
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
|
|
"banger/internal/api"
|
|
"banger/internal/model"
|
|
)
|
|
|
|
func (d *Daemon) BuildImage(ctx context.Context, params api.ImageBuildParams) (model.Image, error) {
|
|
d.mu.Lock()
|
|
defer d.mu.Unlock()
|
|
|
|
name := params.Name
|
|
if name == "" {
|
|
name = fmt.Sprintf("image-%d", model.Now().Unix())
|
|
}
|
|
if _, err := d.FindImage(ctx, name); err == nil {
|
|
return model.Image{}, fmt.Errorf("image name already exists: %s", name)
|
|
}
|
|
baseRootfs := params.BaseRootfs
|
|
if baseRootfs == "" {
|
|
baseRootfs = d.config.DefaultBaseRootfs
|
|
}
|
|
if baseRootfs == "" {
|
|
return model.Image{}, fmt.Errorf("base rootfs is required")
|
|
}
|
|
id, err := model.NewID()
|
|
if err != nil {
|
|
return model.Image{}, err
|
|
}
|
|
now := model.Now()
|
|
artifactDir := filepath.Join(d.layout.ImagesDir, id)
|
|
if err := os.MkdirAll(artifactDir, 0o755); err != nil {
|
|
return model.Image{}, err
|
|
}
|
|
rootfsPath := filepath.Join(artifactDir, "rootfs.ext4")
|
|
script := d.config.CustomizeScript
|
|
if script == "" {
|
|
return model.Image{}, fmt.Errorf("customize script not configured; set runtime_dir or customize_script in config.toml")
|
|
}
|
|
if _, err := os.Stat(script); err != nil {
|
|
return model.Image{}, fmt.Errorf("customize.sh not found at %s", script)
|
|
}
|
|
args := []string{script, baseRootfs, "--out", rootfsPath}
|
|
if params.Size != "" {
|
|
args = append(args, "--size", params.Size)
|
|
}
|
|
kernelPath := params.KernelPath
|
|
if kernelPath == "" {
|
|
kernelPath = d.config.DefaultKernel
|
|
}
|
|
if kernelPath != "" {
|
|
args = append(args, "--kernel", kernelPath)
|
|
}
|
|
initrdPath := params.InitrdPath
|
|
if initrdPath == "" {
|
|
initrdPath = d.config.DefaultInitrd
|
|
}
|
|
if initrdPath != "" {
|
|
args = append(args, "--initrd", initrdPath)
|
|
}
|
|
modulesDir := params.ModulesDir
|
|
if modulesDir == "" {
|
|
modulesDir = d.config.DefaultModulesDir
|
|
}
|
|
if modulesDir != "" {
|
|
args = append(args, "--modules", modulesDir)
|
|
}
|
|
if params.Docker {
|
|
args = append(args, "--docker")
|
|
}
|
|
cmd := exec.CommandContext(ctx, "bash", args...)
|
|
cmd.Stdout = os.Stdout
|
|
cmd.Stderr = os.Stderr
|
|
cmd.Stdin = os.Stdin
|
|
cmd.Dir = d.layout.StateDir
|
|
cmd.Env = append(
|
|
os.Environ(),
|
|
"BANGER_RUNTIME_DIR="+d.config.RuntimeDir,
|
|
"BANGER_STATE_DIR="+filepath.Join(d.layout.StateDir, "image-build"),
|
|
)
|
|
if err := cmd.Run(); err != nil {
|
|
_ = os.RemoveAll(artifactDir)
|
|
return model.Image{}, err
|
|
}
|
|
image := model.Image{
|
|
ID: id,
|
|
Name: name,
|
|
Managed: true,
|
|
ArtifactDir: artifactDir,
|
|
RootfsPath: rootfsPath,
|
|
KernelPath: kernelPath,
|
|
InitrdPath: initrdPath,
|
|
ModulesDir: modulesDir,
|
|
PackagesPath: d.config.DefaultPackagesFile,
|
|
BuildSize: params.Size,
|
|
Docker: params.Docker,
|
|
CreatedAt: now,
|
|
UpdatedAt: now,
|
|
}
|
|
if err := d.store.UpsertImage(ctx, image); err != nil {
|
|
return model.Image{}, err
|
|
}
|
|
return image, nil
|
|
}
|
|
|
|
func (d *Daemon) DeleteImage(ctx context.Context, idOrName string) (model.Image, error) {
|
|
d.mu.Lock()
|
|
defer d.mu.Unlock()
|
|
|
|
image, err := d.FindImage(ctx, idOrName)
|
|
if err != nil {
|
|
return model.Image{}, err
|
|
}
|
|
vms, err := d.store.FindVMsUsingImage(ctx, image.ID)
|
|
if err != nil {
|
|
return model.Image{}, err
|
|
}
|
|
if len(vms) > 0 {
|
|
return model.Image{}, fmt.Errorf("image %s is still referenced by %d VM(s)", image.Name, len(vms))
|
|
}
|
|
if err := d.store.DeleteImage(ctx, image.ID); err != nil {
|
|
return model.Image{}, err
|
|
}
|
|
if image.Managed && image.ArtifactDir != "" {
|
|
if err := os.RemoveAll(image.ArtifactDir); err != nil {
|
|
return model.Image{}, err
|
|
}
|
|
}
|
|
return image, nil
|
|
}
|