Thales Maciel
466a7c30c4
Phase 4 of the daemon god-struct refactor. VM lifecycle, create-op
registry, handle cache, disk provisioning, stats polling, ports
query, and the per-VM lock set all move off *Daemon onto *VMService.
Daemon keeps thin forwarders only for FindVM / TouchVM (dispatch
surface) and is otherwise out of VM lifecycle. Lazy-init via
d.vmSvc() mirrors the earlier services so test literals like
\`&Daemon{store: db, runner: r}\` still get a functional service
without spelling one out.
Three small cleanups along the way:
* preflight helpers (validateStartPrereqs / addBaseStartPrereqs
/ addBaseStartCommandPrereqs / validateWorkDiskResizePrereqs)
move with the VM methods that call them.
* cleanupRuntime / rebuildDNS move to *VMService, with
HostNetwork primitives (findFirecrackerPID, cleanupDMSnapshot,
killVMProcess, releaseTap, waitForExit, sendCtrlAltDel)
reached through s.net instead of the hostNet() facade.
* vsockAgentBinary becomes a package-level function so both
*Daemon (doctor) and *VMService (preflight) call one entry
point instead of each owning a forwarder method.
WorkspaceService's peer deps switch from eager method values to
closures — vmSvc() constructs VMService with WorkspaceService as a
peer, so resolving d.vmSvc().FindVM at construction time recursed
through workspaceSvc() → vmSvc(). Closures defer the lookup to call
time.
Pure code motion: build + unit tests green, lint clean. No RPC
surface or lock-ordering changes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
19 lines
554 B
Go
19 lines
554 B
Go
package daemon
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"banger/internal/paths"
|
|
)
|
|
|
|
// vsockAgentBinary resolves the companion helper the daemon ships
|
|
// alongside its own binary. It's stateless — the signature takes no
|
|
// argument so callers on *Daemon / *VMService / doctor all share one
|
|
// entry point instead of each owning a forwarder method.
|
|
func vsockAgentBinary(_ paths.Layout) (string, error) {
|
|
path, err := paths.CompanionBinaryPath("banger-vsock-agent")
|
|
if err != nil {
|
|
return "", fmt.Errorf("vsock agent helper not available: %w", err)
|
|
}
|
|
return path, nil
|
|
}
|