banger/internal/daemon
Thales Maciel da4a6bf45b
Add lint targets, fix gofmt drift, broaden Makefile build inputs
Three small operational improvements.

1. Makefile build dependencies now cover everything under cmd/ and
   internal/, not just *.go. The previous GO_SOURCES find pattern
   missed embedded assets (catalog.json today, anything else added
   later), so editing a JSON manifest didn't trigger a rebuild and
   left the binary stale. New BUILD_INPUTS covers all files; go's own
   build cache absorbs any redundant invocations. GO_SOURCES is kept
   for fmt/lint targets which still want only Go files.

2. New `make lint` (default + lint-go + lint-shell):
   - lint-go: gofmt -l (fail if any output) and go vet ./...
   - lint-shell: shellcheck --severity=error on scripts/*.sh
   The shell floor is set at error-level for now; the legacy
   make-rootfs-*.sh / make-*-kernel.sh / customize.sh scripts have
   warning-level findings (sudo-cat redirects, heredoc quoting) that
   would block landing this if we tightened immediately. Documented
   as tech debt in docs/kernel-catalog.md alongside a note about
   eventually replacing the per-distro bash with a uniform Go tool.

3. gofmt drift fixed in internal/daemon/imagemgr/build.go,
   session/session.go, and vm_create_ops.go (trailing newline +
   gofmt's preferred function-definition wrapping). Now
   `make lint` passes cleanly; future drift will fail CI/local lint
   instead of accumulating.

AGENTS.md gains a one-line note on make lint.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-16 16:49:17 -03:00
..
dmsnap Extract opstate and dmsnap into subpackages 2026-04-15 16:02:43 -03:00
fcproc Extract fcproc subpackage for firecracker process helpers 2026-04-15 16:11:39 -03:00
imagemgr Add lint targets, fix gofmt drift, broaden Makefile build inputs 2026-04-16 16:49:17 -03:00
opstate Extract opstate and dmsnap into subpackages 2026-04-15 16:02:43 -03:00
session Add lint targets, fix gofmt drift, broaden Makefile build inputs 2026-04-16 16:49:17 -03:00
workspace Extract workspace subpackage with pure repo helpers 2026-04-15 16:37:19 -03:00
ARCHITECTURE.md Refresh daemon docs and mark web UI experimental 2026-04-15 16:44:11 -03:00
capabilities.go Add guest sessions and agent VM defaults 2026-04-12 23:48:42 -03:00
capabilities_test.go Manage image artifacts and show VM create progress 2026-03-21 14:48:01 -03:00
daemon.go Phase 4: remote catalog + banger kernel pull 2026-04-16 15:05:42 -03:00
daemon_test.go Rename experimental Void image to void 2026-04-01 20:15:28 -03:00
dashboard.go Serve a local web UI from bangerd 2026-03-21 16:47:47 -03:00
dns_routing.go Route .vm DNS through systemd-resolved 2026-03-22 15:07:22 -03:00
dns_routing_test.go Route .vm DNS through systemd-resolved 2026-03-22 15:07:22 -03:00
doc.go Refresh daemon docs and mark web UI experimental 2026-04-15 16:44:11 -03:00
doctor.go Remove runtime-bundle image dependencies 2026-03-21 18:34:53 -03:00
fastpath_test.go Manage image artifacts and show VM create progress 2026-03-21 14:48:01 -03:00
guest_sessions.go Extract workspace subpackage with pure repo helpers 2026-04-15 16:37:19 -03:00
guest_sessions_test.go Extract session subpackage with pure guest-session helpers 2026-04-15 16:33:12 -03:00
image_build_ops.go Extract opstate and dmsnap into subpackages 2026-04-15 16:02:43 -03:00
image_seed.go Manage image artifacts and show VM create progress 2026-03-21 14:48:01 -03:00
imagebuild.go Extract imagemgr subpackage with pure image helpers 2026-04-15 16:24:22 -03:00
imagebuild_test.go Extract imagemgr subpackage with pure image helpers 2026-04-15 16:24:22 -03:00
images.go Phase 2: image register --kernel-ref resolves through the catalog 2026-04-16 14:25:50 -03:00
kernels.go Phase 4: remote catalog + banger kernel pull 2026-04-16 15:05:42 -03:00
kernels_test.go Phase 4: remote catalog + banger kernel pull 2026-04-16 15:05:42 -03:00
logger.go Speed up VM create with work seeds 2026-03-18 21:22:12 -03:00
logger_test.go Remove runtime-bundle image dependencies 2026-03-21 18:34:53 -03:00
nat.go Move helper NAT management into Go 2026-03-17 15:07:49 -03:00
nat_test.go Move helper NAT management into Go 2026-03-17 15:07:49 -03:00
opencode.go Manage image artifacts and show VM create progress 2026-03-21 14:48:01 -03:00
ports.go Refine vm ports output 2026-03-19 18:21:04 -03:00
preflight.go Remove runtime-bundle image dependencies 2026-03-21 18:34:53 -03:00
runtime_assets.go Remove runtime-bundle image dependencies 2026-03-21 18:34:53 -03:00
session_attach.go Extract session subpackage with pure guest-session helpers 2026-04-15 16:33:12 -03:00
session_controller.go Extract session subpackage with pure guest-session helpers 2026-04-15 16:33:12 -03:00
session_lifecycle.go Extract session subpackage with pure guest-session helpers 2026-04-15 16:33:12 -03:00
session_stream.go Extract session subpackage with pure guest-session helpers 2026-04-15 16:33:12 -03:00
snapshot.go Extract opstate and dmsnap into subpackages 2026-04-15 16:02:43 -03:00
snapshot_test.go Harden VM stop cleanup for stale snapshots 2026-03-18 12:28:15 -03:00
ssh_client_config.go Configure direct SSH access for .vm hosts 2026-03-22 16:48:42 -03:00
ssh_client_config_test.go Configure direct SSH access for .vm hosts 2026-03-22 16:48:42 -03:00
tap_pool.go Move subsystem state/locks off Daemon into owning types 2026-04-15 15:58:33 -03:00
vm.go Extract fcproc subpackage for firecracker process helpers 2026-04-15 16:11:39 -03:00
vm_authsync.go Split internal/daemon vm.go and guest_sessions.go by concern 2026-04-15 15:47:08 -03:00
vm_create.go Move subsystem state/locks off Daemon into owning types 2026-04-15 15:58:33 -03:00
vm_create_ops.go Add lint targets, fix gofmt drift, broaden Makefile build inputs 2026-04-16 16:49:17 -03:00
vm_disk.go Split internal/daemon vm.go and guest_sessions.go by concern 2026-04-15 15:47:08 -03:00
vm_lifecycle.go Split internal/daemon vm.go and guest_sessions.go by concern 2026-04-15 15:47:08 -03:00
vm_locks.go Move subsystem state/locks off Daemon into owning types 2026-04-15 15:58:33 -03:00
vm_set.go Split internal/daemon vm.go and guest_sessions.go by concern 2026-04-15 15:47:08 -03:00
vm_stats.go Split internal/daemon vm.go and guest_sessions.go by concern 2026-04-15 15:47:08 -03:00
vm_test.go Add guest sessions and agent VM defaults 2026-04-12 23:48:42 -03:00
web.go Serve a local web UI from bangerd 2026-03-21 16:47:47 -03:00
workspace.go Extract workspace subpackage with pure repo helpers 2026-04-15 16:37:19 -03:00
workspace_test.go workspace.export: add base_commit to capture worker git commits 2026-04-14 16:13:05 -03:00